Re: Help with a patch needed

[Stefan Dösinger]

Hi,
> > Any comments / Suggestions from the DirectX people?
>
> Seems ok to me, the logging could do with a but of tarting up.
> It's usually really handy if the instance is logged with each FIXME / TRACE
> e.g.
> instead of
> FIXME("Poorly handled flag DDSCL_SETFOCUSWINDOW\n");
> use
> FIXME("(%p) : Poorly handled flag DDSCL_SETFOCUSWINDOW\n", This);
>
> It's also usefull to log whenever a function returns an error.
> e.g.
>     if (!(cooplevel & (DDSCL_EXCLUSIVE|DDSCL_NORMAL|DDSCL_SETFOCUSWINDOW)))
> { TRACE("(%p) : Call to SetCooperativeLevel failed: cooplevel  !=
> DDSCL_EXCLUSIVE|DDSCL_NORMAL|DDSCL_SETFOCUSWINDOW, returning
> DDERR_INVALIDPARAMS); return DDERR_INVALIDPARAMS;
>     }
>
> that way if returning an error is causing something else to fail it's
> fairly easy to pick up.

Thanks for your help, I've just sent a new patch with the suggested 
improvements.

Stefan