On 11/04/2022 13:22, Jacek Caban wrote:
Hi Gabriel,
On 4/8/22 16:37, Gabriel Ivăncescu wrote:
Hi Jacek,
Any news about these 2 patches?
They look mostly good, but it looks like TestBot is not happy with those tests. Also, is there a reason to use Object.prototype.hasOwnProperty.call(s,"...") instead of simply s.hasOwnProperty(s, "...")?
Thanks,
Jacek
That looks like a bug in Windows 8's mshtml jscript engine, I can't explain it in any other way (and why it happens only on Windows 8 VMs). Should I leave the test out? I don't know how to mark it as broken for Windows-only in js tests.
And sorry about the Object.prototype.hasOwnProperty, it's just a habit when I write tests so I know exactly what it's tested (bypassing any overrides in the prototype chain). There's no other reason. I know I changed it before, but I either keep forgetting to change them all or keep rewriting it :-/