Re: [PATCH 1/4] server: Allow named pipes creation with device file as root directory.

[Paul Gofman]

On 11/11/20 22:09, Alexandre Julliard wrote:
> Paul Gofman  writes:
> > @@ -1350,28 +1350,39 @@ DECL_HANDLER(create_named_pipe)
> >      struct named_pipe *pipe;
> >      struct pipe_server *server;
> >      struct unicode_str name;
> > - struct object *root;
> > - struct object *root = NULL;
> > const struct security_descriptor *sd;
> > - const struct object_attributes *objattr = get_req_object_attributes( &sd, &name, &root );
> > - const struct object_attributes *objattr = get_req_object_attributes( &sd, &name, NULL );
>
> It should be possible to make get_req_object_attributes() not require a
> directory instead.

Will it be better to pass object ops to get_req_object_attributes() and
update the usages accordingly? Possibly allowing NULL which will default
to directory.