Andrew Eikum wrote:
I think the GetPosition and GetCurrentPadding failures are caused by using GETOSPACE instead of GETODELAY in GetPosition().
Please write that patch too. It needs good testing to get the start/stop/underrun corner cases right.
My hope is that Wine-1.4.0 will have 3 drivers of comparable if not equal quality.
What I plan is to submit my render patch with almost all GetPosition tests lifted behind if(winetest_debug>1): render.c:1062: Tests skipped: Rerun with WINETEST_DEBUG=2 for GetPosition tests.
This one perhaps should move as well, although it indicates a problem. render.c:1166: Test failed: Position should have been further along...
render.c:1227: Test failed: GetCurrentPadding returned 512, should be 0 No idea, please check.
render.c:1228: Test failed: Position 142756 at end vs. 143268 submitted frames In shared mode, the end position must be the sum of released frames. In exclusive mode, I've seen some cards return a little less.
Your RenderClient patch looks good.
Regards, Jörg Höhle