Makes sense. I will send another patch once it is commited.
Christian
Message du 09/09/11 09:53 De : "Frédéric Delanoy" A : wine-devel@winehq.org Copie à : "Christian Costa" Objet : Re: [PATCH] cmd: Add help info for xcopy
On Fri, Sep 9, 2011 at 09:16, Christian Costa wrote:
--- a/programs/cmd/builtins.c +++ b/programs/cmd/builtins.c @@ -68,7 +68,8 @@ static const WCHAR parmNoY[] = {'/','-','Y','\0'}; static const WCHAR nullW[] = {'\0'};
const WCHAR externals[][10] = {
- {'A','T','T','R','I','B','\0'}
- {'A','T','T','R','I','B','\0'},
- {'X','C','O','P','Y','\0'}
Patch is OK, but for consistency, shouldn't the externals be put at the start of wcmdmain.c, just after the inbuilt[][]10]? This way, you could see directly which command is built-in, and which is external.
Frédéric