On 01/25/2010 09:37 AM, Michael Karcher wrote:
Am Montag, den 25.01.2010, 15:27 +0800 schrieb Dmitry Timoshkov:
The current code misdetects both Windows XP and Wine as Win9x and skips some tests due to this. The SetParent tests were not passing on XP, so this patch also removes the tests that fail on XP SP3.
These should be 2 separate patches.
And according to http://test.winehq.org/data/e2af560aa3c23a672d8680f91f3e1b8793d5827f/index_X... SetParent tests pass under XP just fine.
No, they don't pass on Windows XP. But they also don't fail on Windows XP, because they are not run at all, because the Win9x detection is wrong.
I just checked with a XP-SP3 box on winetestbot and added the flag to show the winetest successes:
https://winetestbot.geldorp.nl/JobDetails.pl?Key=420
This clearly shows that the tests are run. I'm not saying they run on every XP box btw.
Nonetheless, it could be a smart move to have 1 point of detection instead of several.