Re: [PATCH vkd3d 5/5] vkd3d-shader/hlsl: Parse the Sample() method.

[Zebediah Figura (she/her)]

On 11/2/21 09:04, Giovanni Mascellani wrote:
> Hi,
>
> On 02/11/21 01:43, Zebediah Figura wrote:
> > +        if (!(coords = add_implicit_conversion(ctx, instrs, 
> > params->args[1],
> > -
> >
> > ctx->builtin_types.vector[HLSL_TYPE_FLOAT][sampler_dim - 1], loc)))
> > +            coords = params->args[1];
>
> I would suggest to use the hlsl_get_vector_type helper.

Right, thanks. Most of these patches I've been submitting were written 
before that helper was...