Re: fixes for -Wmissing-declarations and -Wwrite-strings warnings

[Andreas Mohr]

Hi,

On Thu, Jun 02, 2005 at 08:31:36PM +0900, Mike McCormack wrote:
> ChangeLog:
> - fixes for -Wmissing-declarations and -Wwrite-strings warnings

Argh, this is what I had done recently but didn't manage to submit yet.
(I told in a mail that I had done programs/ and tools/)
> -static char *ignored_fstypes[] = {
> +static const char *ignored_fstypes[] = {
>      "devpts",
>      "tmpfs",
>      "proc",
> @@ -61,7 +61,7 @@ static char *ignored_fstypes[] = {
>      NULL
>  };

Imperfect - it should be static const char * const ignored_fstypes[]
since otherwise the ignored_fstypes pointer is still non-const (objdump -x)
which it doesn't need to be (may mark more memory pages as read-write than
necessary).

Sure, your objective was to fix all strict compiler warnings which that patch
probably did successfully, but why not go that extra mile...

Andreas Mohr