On 19 May 2010 09:56, Stefan Dösinger stefandoesinger@gmx.at wrote:
Am 19.05.2010 um 00:38 schrieb Roderick Colenbrander:
This patch series removes the responsibility for enabling/disabling the texture_target from the 'set_shader' stage of the blit_shader.
I disagree with this patch. glEnable(GL_TEXTURE_2D) is the fixed function pipline's way of putting the right texture target into the "TEX dst, src, sampler, dimension" instruction. They are in the ARB blitter only because of my laziness - it is using the fixed function pipeline instead of an equivalent shader.
Yup, as explained yesterday, this is something that should be internal to a specific blit implementation. This series is a change in the opposite direction.
Technical issues with this series aside, I think it's too close to 1.2 for making architectural changes. IMO the focus should be mainly on fixing regressions and minor bugs.