On Tue, 16 Apr 2019, at 12:20, Zhiyi Zhang wrote:
You can write some conformance tests and verify the behavior on TestBots(https://testbot.winehq.org/)
Thanks!
I submitted another email with just the tests, sorry for the noise. I was not sure if a reply patch would be picked up? It looks like it worked on Windows. I manually downloaded the built exe, and it failed on unpatched Wine.
I wasn't able to build the Windows test executable with mingw myself. Has make crosstest changed, or it is just me?
"SHCreateDirectoryExW returned %d. Expected %d",
I missed a newline at the end of one of the ok strings
Should I add this newline, squash both of my commits, and submit a new version of this patch? Any other hints or comments?
Thank you!