On Fri, Aug 04, 2017 at 04:17:14PM +0300, Andrey Gusev wrote:
Signed-off-by: Andrey Gusev andrey.goosev@gmail.com
dlls/netapi32/netapi32.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/dlls/netapi32/netapi32.c b/dlls/netapi32/netapi32.c index 278d4528b0..0236a2ad53 100644 --- a/dlls/netapi32/netapi32.c +++ b/dlls/netapi32/netapi32.c @@ -3024,7 +3024,7 @@ DWORD WINAPI DsGetDcNameW(LPCWSTR ComputerName, LPCWSTR AvoidDCName, FIXME("(%s, %s, %s, %s, %08x, %p): stub\n", debugstr_w(ComputerName), debugstr_w(AvoidDCName), debugstr_guid(DomainGuid), debugstr_w(SiteName), Flags, DomainControllerInfo);
- return ERROR_CALL_NOT_IMPLEMENTED;
- return ERROR_SUCCESS;
}
DWORD WINAPI DsGetDcNameA(LPCSTR ComputerName, LPCSTR AvoidDCName, @@ -3034,7 +3034,7 @@ DWORD WINAPI DsGetDcNameA(LPCSTR ComputerName, LPCSTR AvoidDCName, FIXME("(%s, %s, %s, %s, %08x, %p): stub\n", debugstr_a(ComputerName), debugstr_a(AvoidDCName), debugstr_guid(DomainGuid), debugstr_a(SiteName), Flags, DomainControllerInfo);
- return ERROR_CALL_NOT_IMPLEMENTED;
- return ERROR_SUCCESS;
}
This can't be right. These functions are supposed to return a ptr to an allocated DOMAIN_CONTROLLER_INFO in the final parameter. If you return ERROR_SUCCESS, the app will likely dereference that uninitialized pointer.
Huw.