Mike Hearn wrote:
And there are a few small style nits, for instance there's usually no reason to change "void *foo" to "void *foo = NULL", you want it to remain uninitialized because that way the compiler will warn if it's ever used before being set to something: superior to blindly using a NULL ptr with no warning I'm sure you'll agree.
Let's see:
gcc version 4.1.2 20060729 (prerelease) (Debian 4.1.1-10)
mike@black:~/wine$ cat foobar.c void foo(int *); void bar(void) { int x; if(x) foo(&x); } mike@black:~/wine$ gcc -Wall -c foobar.c mike@black:~/wine$
Superior, if the compiler did happen to warn you...
Mike