On Thu, Mar 26, 2015 at 3:45 PM, Piotr Caban piotr.caban@gmail.com wrote:
Hi,
On 26/03/15 19:21, Sebastian Lackner wrote:
On 26.03.2015 19:10, Piotr Caban wrote:
The inheritance doesn't occur when function from ntdll are used for setting DACL. This makes your code inside server incorrect. Also your code is not checking handle permissions correctly.
does that mean you reviewed our code? Would you please give some more details to us about the error you found? Feel free to open a bug report on bugs.wine-staging.com with your results.
I've not really reviewed it, I've only skimmed the diff. According to my testing NtSetSecurityObject is only setting supplied DACL, it's not adding inherited entries.
I also haven't seen the implementation from wine-staging tree earlier (I think these patches were not mentioned anywhere on wine bugzilla/were never sent to wine but maybe I've missed something).
Thanks, Piotr
https://bugs.winehq.org/show_bug.cgi?id=33576#c10