Re: [2/2] ntdll: Implement FILE_ATTRIBUTE_HIDDEN and FILE_ATTRIBUTE_SYSTEM support (take 6)

[Detlef Riekenberg]

On Do, 2009-10-01 at 16:59 -0700, Dan Kegel wrote:
> +/***********************************************************************
> -
> -
>       wrap_getxattr
> -
> - Retrieve extended attribute of posix file into given buffer.
> -
> - Use fd if given, else use fname; caller only sets one or the
>
> other.
> - */
>
> +static int wrap_getxattr(int fd, const char *fname, const char
> *attrname, char *attrbuf, int attrbuflen)

Code, which is called very often, should produce as less overhead as
possible.
I suggest to use "static inline".
Seperate implementations for fd and fname should also make a difference.

Your code handle different parameter for the attr functions.
Is it possible, that code, which is compiled for one ABI version can
call
the implementation of the other ABI version?

When Wine depends on libattr and libattr-dev after you Patch,
all packagers should get this information.