On 2/17/21 18:01, Henri Verbeet wrote:
Perhaps an "is_software_device_type()" would be clearer than testing the index of the test_devices[] array.
Do you expect we'll have more RGB/software device tests in the future?
Yes, I was going to add at least the test for actual rendering to the _SYSMEM rendertarget and locking it in process. I also have a specific test for using the surface without DDSCAPS_TEXTURE as texture in Staging [1] which I was going to add some time later when we have the sysmem rendertarget support in place.
Perhaps it makes sense to handle this the same way we handle feature levels in the d3d11 tests. I.e., passing the device type as a parameter to the test function, and then simply invoking it multiple times. One of the advantages would be that we could check whether a particular device type is supported in a common caller.
I will do that.
As an aside, I'm not sure whether I mentioned this before or not, but splitting ddraw test changes per ddraw version is probably one of the few cases where splitting patches doesn't do much for making review easier. If it's the same to you, feel free to combine these into a single patch in the future.
Ok, I will send the update as a single patch.
1. https://github.com/wine-staging/wine-staging/blob/master/patches/ddraw-Textu...