RFC: Adding annotations to function declarations to improve static analysis

[Rob Shearman]

Hi all,

This will be talked about in more detail at WineConf tomorrow, but I
just thought I'd throw this out there as a bit of background to any
discussions.

Adding annotations to function declarations allows Prefast to pick up
certain classes of bugs with varying degrees of false positives. In
particular, with patches like the attached applied
byte-count/element-count mismatches can be detected with no false
positives and relatively few false positives for off-by-one errors and
other buffer overruns. Whilst this could be maintained outside of the
main Wine tree it would be more convenient in terms of automation of
Prefast runs if a vanilla Wine tree can be used (i.e. the annotation
patches are in the official tree).