Re: New tests failing ...

[Stefan Leichter]

Am Dienstag 21 Januar 2003 20:02 schrieb Alexandre Julliard:
> Stefan Leichter  writes:
> > ChangeLog
> >
> > fixed tests in dlls/winspool/tests/info.c when wine runs in NT-like mode
>
> This kind of things should only be done if there is an actual app that
> depends on it. Otherwise we shouldn't do version checks at all, just
> fix the test to cope with all versions.

The behavior that is check in the tests is not documented. Does fixing the 
test mean in this case remove the test ? e.g. like this:

--- ../wine/dlls/winspool/tests/info.c	Wed Jan 15 01:50:48 2003
+++ dlls/winspool/tests/info.c	Tue Jan 21 21:14:09 2003
@@ -26,6 +26,7 @@
 {   LPBYTE buffer = NULL;
     DWORD  cbBuf, pcbNeeded;
     BOOL   res;
+#ifdef UNDOCUMENTED
     OSVERSIONINFOA ver;

ver.dwOSVersionInfoSize = sizeof(OSVERSIONINFOA);
@@ -33,6 +34,7 @@
         ok( 0, "GetVersionExA failed!");
         return ;
     }
+#endif /* UNDOCUMENTED */

(void) GetPrinterDriverDirectoryA( NULL, NULL, 1, NULL, 0, &cbBuf);

@@ -56,6 +58,7 @@
         "last error set to %ld instead of ERROR_INSUFFICIENT_BUFFER",
         GetLastError());

+#ifdef UNDOCUMENTED
     res = GetPrinterDriverDirectoryA( NULL, NULL, 1, NULL, cbBuf, &pcbNeeded);
     if(ver.dwPlatformId == VER_PLATFORM_WIN32_NT) {
         ok( !res , "expected result == 0, got %d", res);
@@ -91,6 +94,7 @@
             "last error set to %ld instead of ERROR_INVALID_PARAMETER",
              GetLastError());
     }
+#endif /* UNDOCUMENTED */

HeapFree( GetProcessHeap(), 0, buffer);
 }