Re: [PATCH 5/5] d3dx11: Implemented D3DX11CompileFromFileW

[Matteo Bruni]

2016-09-20 1:56 GMT+02:00 Fabian Maurer :
> Thanks for your feedback.
> > > - UINT filename_converted_len;
> >
> > Probably you can call it just "size".
>
> Are you sure? I tried to make it less ambiguous, since there are two sizes
> used.

Right. Whatever is fine I guess, but using "_size" instead of "_len"
seems valuable for consistency.
> > This would be okay otherwise but, as mentioned for patch [4/5], maybe
> > it's a good idea to implement and make use of
> > D3DX11CreateAsyncFileLoaderW() here too.
>
> I fixed the other issues on my local branch and I'll try to get the async parts
> right.

Cool, looking forward to it.