Re: [PATCH 1/6] user32: Add get/release routines for accessing cursor frames.

[Alexandre Julliard]

Erich Hoover  writes:
> @@ -135,6 +139,16 @@ static void release_icon_ptr( HICON handle, struct cursoricon_object *ptr )
>      release_user_handle_ptr( ptr );
>  }
>
> +struct static_cursoricon_object *get_icon_data( struct cursoricon_object *obj, int istep )
> +{
> - return &obj->frames[istep];
>
> +}
> -
>
> +void release_icon_data( struct cursoricon_object *obj, int istep, struct static_cursoricon_object *icon_data )
> +{
> - /* placeholder */
>
> +}

I find your data structures confusing. You add a concept of icon_data
separate from icon_ptr, but it doesn't correspond to the data
structures, there's no such thing as an icon_data. There should be a way
of making this clearer.