Re: [PATCH] user32: Fix error handling in MapWindowPoints, ClientToScreen and ScreenToClient and add tests for them. (try 3)

[Dmitry Timoshkov]

Christian Costa  wrote:
> BOOL WINAPI ClientToScreen( HWND hwnd, LPPOINT lppnt )
>  {
> - DWORD error = GetLastError();
> -
> - if (!hwnd)
> - {
> -
>    SetLastError( ERROR_INVALID_WINDOW_HANDLE );
> -
>    return FALSE;
> - }
> -
> - SetLastError( 0xdeadbeef );
> MapWindowPoints( hwnd, 0, lppnt, 1 );
> -
> - if (GetLastError() != 0xdeadbeef)
> -
>    return FALSE;
> -
> - SetLastError(error);
> return TRUE;
>
> }

As been said before these games with saving/restoring last error value
are broken.