On 11/20/20 16:20, Paul Gofman wrote:
On 11/20/20 15:54, Huw Davies wrote:
On Fri, Nov 20, 2020 at 02:55:48PM +0300, Paul Gofman wrote:
diff --git a/programs/wineboot/wineboot.c b/programs/wineboot/wineboot.c index 05a5ee6aa62..b3a28444a06 100644 --- a/programs/wineboot/wineboot.c +++ b/programs/wineboot/wineboot.c @@ -332,6 +332,8 @@ static void create_user_shared_data(void) break; } data->ActiveProcessorCount = NtCurrentTeb()->Peb->NumberOfProcessors;
- data->ActiveProcessorAffinity = data->ActiveProcessorCount >= 64
Shouldn't this be >= 8 * sizeof(ULONG_PTR) ?
Yes, I will update it.
I actually missed _PTR part. I actually suggest we better simplify things and use sizeof(ULONGLONG). Yes, there is a processor count limit of 32 on Win32, but in this case NtCurrentTeb()->Peb->NumberOfProcessors should already obey the limit (and MAXIMUM_PROCESSORS defined as 32 on Win32), so for that case this check should be just redundant.