Re: [PATCH 3/5] ws2_32: Drop support for getting the IP_HDRINCL socket option

[Zebediah Figura (she/her)]

On 8/13/21 12:56 AM, Alex Henrie wrote:
> @@ -1453,12 +1451,10 @@ todo_wine
>               k = 99;
>               SetLastError(0xdeadbeef);
>               err = getsockopt(s, IPPROTO_IP, IP_HDRINCL, (char *) &k, &size);
> -
>        ok(err == -1, "Expected -1, got %d\n", err);
>         todo_wine
> -
>        {
> -
>            ok(err == -1, "Expected -1, got %d\n", err);
>             ok(GetLastError() == WSAEINVAL, "Expected 10022, got %d\n", GetLastError());
> -
>            ok(k == 99, "Expected 99, got %d\n", k);
> -
>        }
> -
>        ok(k == 99, "Expected 99, got %d\n", k);
>     }
>     else /* <= 2003 the tests differ between TCP and UDP, UDP silently accepts */
>     {

If this is supposed to return WSAEINVAL, any reason not to do so in this 
patch?