On 19.08.2016 11:43, Alex Henrie wrote:
Cc: Sebastian Lackner sebastian@fds-team.de
v8 initializes V_ERROR(&var), item, item2, and i correctly. It also adds checks that the test files were created and written successfully.
Signed-off-by: Alex Henrie alexhenrie24@gmail.com
dlls/shell32/tests/Makefile.in | 2 +- dlls/shell32/tests/shelldispatch.c | 229 +++++++++++++++++++++++++++++++++++-- 2 files changed, 219 insertions(+), 12 deletions(-)
I think this patch is unfortunately still a bit too noisy to be applied separately. If you want to keep the "bruteforce" tests I would suggest to move the implementation into the first patch, or alternatively change the FIXME to a TRACE. Besides that I am basically fine, although there are probably some ways how to improve the code style a bit further.
Regards, Sebastian