RE: Converting source to unicode, bug 28189

[Hugh McMaster]

Hi Akihiro,

Many thanks for your comments.

On Friday, 14 February 2014 3:06 AM, Akihiro Sagawa wrote:
> Regarding your patch, attachment #47519, I roughly read the code and post comments at the following points:
> 5. Double quote handling: command_line is advanced when the code
> finds a double quote character. When it updates wsCommandLine?

Good catch!  :)
> - Silent handling: Many times, it refers Silent variable before
>
> calling output_write function. How about moving the check to the
>   function?

Do you mean that I should add the Silent boolean value as a variable in the function call?