On Wed, Feb 23, 2011 at 08:24:46PM +0300, Nikolay Sivov wrote:
}
- break; case DL_CANCELDRAG: /* Clear drag arrow */ DrawInsert(hwnd, hwndList, -1);
Why? Looks to me it's fine to clear on dropped case too. Coverity is a bit paranoid about missed breaks.
A missing break is not trivial to detect; especially if something is done in a specific case. That's why Wine has a ton of "/* fall through */" annotations. IMHO they should be added here too .
Well, there's no third option basing on code - report all or report none, cause you can't figure out automatically is it ok to fall or not. A comment you mean is kind of suppression sign for checker?. Speaking about this particular case, I have a better comboex fix in mind, and for toolbar I think it's fine to add a comment.
lint used
/* FALLTHROUGH */
as a tag. Not sure if Coverity uses it, but we could use somesuch for tagging such places.
Ciao, Marcus