Re: [PATCH 1/3] Update POOL_TYPE enumeration based on MSDN

[Zebediah Figura]

On 01/09/18 00:40, Derek Lesho wrote:
> Update POOL_TYPE enum to include types listed on MSDN, including
> NonPagedPoolExecute, which is needed for Battleye.
> Signed-off-by: Derek Lesho
>
> include/ddk/wdm.h | 31 +++++++++++++++++++++++--------
>  1 file changed, 23 insertions(+), 8 deletions(-)
>
> diff --git a/include/ddk/wdm.h b/include/ddk/wdm.h
> index 0cd1673dbe..a639b3c7b7 100644
> --- a/include/ddk/wdm.h
> +++ b/include/ddk/wdm.h
> @@ -183,14 +183,29 @@ typedef struct _VPB {
>  } VPB, *PVPB;
>
> typedef enum _POOL_TYPE {
> - NonPagedPool,
> - PagedPool,
> - NonPagedPoolMustSucceed,
> - DontUseThisType,
> - NonPagedPoolCacheAligned,
> - PagedPoolCacheAligned,
> - NonPagedPoolCacheAlignedMustS,
> - MaxPoolType
> - NonPagedPool                          ,
> - NonPagedPoolExecute                   ,
> - PagedPool                             ,
> - NonPagedPoolMustSucceed               ,
> - DontUseThisType                       ,
> - NonPagedPoolCacheAligned              ,
> - PagedPoolCacheAligned                 ,
> - NonPagedPoolCacheAlignedMustS         ,
> - MaxPoolType                           ,
> - NonPagedPoolBase                      ,
> - NonPagedPoolBaseMustSucceed           ,
> - NonPagedPoolBaseCacheAligned          ,
> - NonPagedPoolBaseCacheAlignedMustS     ,
> - NonPagedPoolSession                   ,
> - PagedPoolSession                      ,
> - NonPagedPoolMustSucceedSession        ,
> - DontUseThisTypeSession                ,
> - NonPagedPoolCacheAlignedSession       ,
> - PagedPoolCacheAlignedSession          ,
> - NonPagedPoolCacheAlignedMustSSession  ,
> - NonPagedPoolNx                        ,
> - NonPagedPoolNxCacheAligned            ,
> - NonPagedPoolSessionNx
>
> } POOL_TYPE;
>
> typedef struct _WAIT_CONTEXT_BLOCK {

MSDN, like the SDK headers, is copyrighted; you can't copy and paste
directly from it.

Moreover, this changes the values for some existing types, which doesn't
seem correct. MSDN even says that NonPagedPoolExecute is a synonym for
NonPagedPool.