On 5/18/22 16:30, Chip Davis (@cdavis5e) wrote:
On Wed May 18 20:22:09 2022 +0000, Chip Davis wrote:
- If we're moving things around, I believe we also want to move
DECOMPRESS to the "base flags" group. No we don't. AIUI that's for when the implementation doesn't support uploading the compressed data directly, which can and does vary by resource type--most infamously, OpenGL doesn't support compressed volume textures.
- Patches 10 and 11 in particular are an awful lot of churn, and the
naming isn't clearly an improvement.
Would it help if I broke patch 10 up into a patch per flag? (Acting on your second suggestion allowed me to eliminate patch 11.)
I don't know that really helps, since I think most of the churn comes from renaming the field itself.
Personally I think "caps" makes enough sense that I'd be inclined to just keep it.
The one remaining comment I failed to remember the first time is that as long as we're moving things around, ideally we'd move away from the ddraw-style naming, and say WINED3D_FORMAT_ATTR_* / WINED3D_FORMAT_CAP_*. I hate to ask to rewrite the whole series again, but hopefully some sed magic should make that relatively painless?