On 5/7/07, Duane Clark fpga@pacbell.net wrote:
Dmitry Timoshkov wrote:
"Vitaly Budovski" vbudovski@gmail.com wrote:
Now that you got rid of sqrt calls usage of float numbers internally doesn't look justified (to me) anymore.
Only because in this instance it is used with integer data. It doesn't need to be limited to just integer values. Besides, what would be gained by changing it to integers as you suggest?
What would be gained is an additional speed. Since this code is supposed to be used to handle palette/color data there is no need to use floats at all.
While I cannot vouch for the accuracy, this might be of interest: http://lua-users.org/wiki/FloatingPoint
Vitaly,
I think I recommend using just integers, and make this private for DIBs. Speed is nice for what we can use it for. If someone later needs the float use, then we can create a separate float version and included where-ever it's used. There is nothing wrong with having two versions when each is justified. If you can get your code accepted I'll probably move it over to the DIB engine eventually. If the wined3d people want to use it, I could make it available somehow?
Jesse