Martin Wilck Martin.Wilck@Fujitsu-Siemens.com writes:
OK - but I am not sure if the second change can't break something for 2.4 or other POSIX systems - here POLLHUP would IMO mean that the peer has closed both sides of the connection, justifying to reset FD_WRITE and FD_WINE_CONNECTED just as we do with POLLERR. Perhaps we should carry out a small test at wineserver startup to determine whether a shutdown() can cause a POLLHUP to be received (below a small proof-of-concept test program that shows how that could work - I tested it on 2.2 and 2.4, it yields the expected results).
We may want to do something like that yes. I'm not sure the extra FD_WRITE will really be a problem in practice, but if we can avoid it it's certainly preferable.
PS I'd be grateful if you could also help me out with that GUID question...
I guess you should simply use the same GUIDs than Microsoft does.