Oops, forgot to reply all.
Charles Davis wrote:
James McKenzie wrote:
Charles Davis wrote:
Hi,
My name is Charles Davis, but you all can call me "Chip".
I'm new to Wine development, and frankly, I'm kinda scared because I've heard and read that getting patches into Wine is very difficult. In fact, every time I got ready to send this first patch, I chickened out and couldn't do it. So, I want someone to review this patch to see if there's anything wrong with it.
Might help to add testcases to show that this is what Windows does and that Wine correctly emulates these actions.
Then why isn't there already a testcase for this? This is nearly impossible to test automatically. (You need a CD in the drive.) Interactively... well, you got me there.
It also might REALLY help if you can state where you found this in MSDN or on a public site. Otherwise this leaves your code as suspect and it will not be added.
It's under "Win32 and COM Development/Windows Driver Kit/Device and Driver Technologies/Storage Devices" on MSDN. Under the Reference section, there's a list of all the IOCTLs supported by Windows for all storage devices--including CD-ROM devices. Then again, I hear that MSDN doesn't have the full story. Maybe I should write a testcase... and I do have a Windows XP machine for testing.
If this solves a bug, you might also want to add that too.
It doesn't. Not that I know of anyway. (Maybe I should do a search?) I stumbled upon a bunch of unimplemented stuff in this file while trying to add IOCTL_SCSI_PASS_THROUGH support. (Basically the whole file, save for the eject and TOC IOCTLs, was unimplemented on Mac OS.) So I decided, "Since nobody else is going to implement this, I might as well." Then again, maybe there's a good reason they're not yet implemented (nobody needs this stuff).
Thank you.
James McKenzie
Thanks for your input, James.
Chip