Hi Erich,
The patch looks mostly good now but it causes compilation warnings. The prototype of swscanf function is incorrect: +static int (__cdecl *p_swscanf)(const char *str, const wchar_t* format, ...); Also result variable is not used.
Thanks, Piotr
On 10/21/19 6:00 PM, Erich E. Hoover wrote:
On Mon, Oct 21, 2019 at 4:33 AM Piotr Caban piotr.caban@gmail.com wrote:
... msvcr80 is the first dll that was changed. Attaching a hacky test that shows it (it also shows difference is %S format handling but it's not something that has to be fixed as part of your patch).
Thanks Piotr, I was trying to do this on Friday and didn't realize that the manifest needed to be changed for it to work. At some point is it worth adding tests for these older msvcr* dlls so that it's easier to test against them?
Anyway, I believe that this version now has all of the changes that you have requested - so please let me know if I missed something.
Best, Erich