Re: [PATCH 1/4] wined3d: Vertex fog uses the absolute eye position z (v3).

[Joachim Priesner]

I really appreciate you giving me feedback, thanks! (Your guidance on the abs() patch was very helpful, too.)
> > [PATCH 3/3] comctl32: Implement the TaskDialog function (try 2)
> > [PATCH 2/3] comctl32: Basic implementation of TaskDialogIndirect
> > (try 2) [PATCH 1/3] comctl32: Move TaskDialogIndirect function to
> > separate file (try 2)
>
> I have never touched comctl32, so I'm not really qualified here. The
> overall feeling is that the code looks like is is copypasted together
> from various places. (The style inconsistencies trigger that
> suspicion). Combined with the lack of tests it raises the question of
> how solid this implementation is in the long run.

Yes, this is mostly derived from MessageBoxW.

I'll try to make this more consistent and add more tests as far as it is possible.
> Also the defines like TD_WARNING_ICON look like they're copypasted
> from Microsoft's header.

What would be the way to define them properly?

Best
Joachim