Re: [PATCH v3] iphlpapi: Add support for ConvertLengthToIpv4Mask()

[Huw Davies]

On Mon, Mar 19, 2018 at 12:40:07PM +0000, Huw Davies wrote:
> On Sun, Mar 18, 2018 at 09:40:46PM +0100, Dagfinn Reiakvam wrote:
> > From: Uberdaff
>
> I'm not sure why you're including the From: line, simply leave it out
> unless you're sending a patch from somebody else.
> > index 97284ed..62437e0 100644
> > --- a/dlls/iphlpapi/iphlpapi_main.c
> > +++ b/dlls/iphlpapi/iphlpapi_main.c
> > @@ -3223,6 +3223,30 @@ DWORD WINAPI ConvertInterfaceNameToLuidW(const WCHAR *name, NET_LUID *luid)
> >  }
> >
> > /******************************************************************
> > -
> > - ConvertLengthToIpv4Mask (IPHLPAPI.@)
> > - */
> >
> > +DWORD WINAPI ConvertLengthToIpv4Mask(ULONG mask_len, PULONG mask)

Also, one more thing, we tend to prefer 'ULONG *' to 'PULONG', so please
change this.

Huw.