Re: [PATCH 3/7] reg: Add path/key conversion functions

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2014-11-06 17:33, schrieb Jonathan Vollebregt:
> I ran a quick one on testbot myself that confirmed it, but didn't
> write up a proper one.

Please add one. It answers why the code is in here and not another place.

I'm OK if you send the advapi32 test after the reg.exe patches.
> Speaking of - since the type_get_wchar and wchar_get_type
> functions return 2 states like path_get_rootkey, should I have them
> return pointers too? (Or DWORD -1 for error in the case of
> wchar_get_type)

Yes. Generally speaking, don't use more parameters / return pointers
than necessary. If there's only one reason why a pointer-returning
function can fail you don't need another channel to communicate why it
failed.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJUW6exAAoJEN0/YqbEcdMwdu0P/0dVyml7/3S4I191P3H5XGn/
SA9f9Goolqw8SYi/aSi+K9DlvLaXjyLZEm0Pf3Vmbgg6uWDm/GV+OPqiV/ILxoRl
crNlHzz8vfT57bXck4K+Qi/xapTWoJy+F2xL4SScShuR82UMbUlYfNlBYx0t9upf
R1tBtsLRNjjkE9mZ7y+Qyipi9lYij7WuEuzC+YIlbR6hUuZ24U4nEbUtZDY3B1Z8
7lOdfriyUge4gjTWbmqC1MQJD9BbDvlW/4s33q5PO+JTtDbrlqRz0zygMY5uxASz
zq8uz7/u3ff9UKmqyWWGxuwLajDdzqYkKCEvnzcjX78euDBhwdyoCVkJ0h67+JEz
NZtdbnTDe+pdqNWslklf9vYuaxH3IuTgPz1FPJ8gih1oSlCNWWNEDj1VYny/F8mK
QeC4vinN7KimqC+0GTKKT353hFIWpmA0ug6ochSdVJMi0S8APbbmE/phInOBzAGQ
LKFa9MxbAEUDQyp3tVtqaHmqBjPExuJtLKd/ZwozhPmRG+CChLTA4ikhNgbqyOe3
OnwpiO4/nW/tUulZTkZ9Jq7tB6Lj43UBdLlLc2td0YrL7ARZ8sHde2KYiUMaXnIn
q8jxc8uvXMCgdZcOqmfSiV8Ot8vY8USyKYvWfSdosf9uZDymxY6CI0FmpQB2KAbc
nZ3aaFyVQDXwzd+trpgx
=NBtH
-----END PGP SIGNATURE-----