On Fri, Sep 11, 2020 at 1:53 AM Alexandre Julliard julliard@winehq.org wrote:
Alex Henrie alexhenrie24@gmail.com writes:
Signed-off-by: Alex Henrie alexhenrie24@gmail.com
These functions are incredibly slow on Windows. To avoid timeouts, I had to put the tests in protocol.c rather than the crowded sock.c.
The right way to avoid timeouts is to make the test faster. It doesn't seem necessary to call these functions thousands of times.
Okay. Which getservbyport tests should I drop? Maybe only test that the ports we expect to be defined are defined and not test that the parts we expect to not be defined are not defined?
Alternatively, I could ask Jeremy to buy new, faster hardware for the testbot VMs.
-Alex