Re: [PATCH 1/1] wininet/test: Check null pointer in InternetGetSecurityInfoByURLW

[Wei Xie]

Because last error not set as 0 in vista and w2008, but others do it. If set last error as 0xdeadbeef in these two tests, the test will failed
https://testbot.winehq.org/JobDetails.pl?Key=35144

------------------ Original ------------------
From:  "Jactry Zeng";
Date:  Tue, Jan 9, 2018 04:28 PM
To:  "Wei Xie";
Cc:  "wine-devel";
Subject:  Re: [PATCH 1/1] wininet/test: Check null pointer in InternetGetSecurityInfoByURLW

Hi Wei,

Thanks for contribution!
I have a question about the tests:

+
+        SetLastError(0);
+        res = pInternetGetSecurityInfoByURLA(url, &chain, NULL);
+        ok_(__FILE__,line)(res && GetLastError() == 0,
+                           "InternetGetSecurityInfoByURLA failed returned: %x(%u), expected success\n", res, GetLastError());
+
+        SetLastError(0);
+        res = pInternetGetSecurityInfoByURLA(url, NULL, &flags);
+        ok_(__FILE__,line)(res && GetLastError() == 0,
+                           "InternetGetSecurityInfoByURLA failed returned: %x(%u), expected success\n", res, GetLastError());
     }else {

Why not set last error as 0xdeadbeef in these two tests?

2018-01-08 15:57 GMT+08:00 Wei Xie :