Re: [PATCH v4 1/7] shell32/autocomplete: Fix handling of Return key when an auto-suggestion item is selected

[Huw Davies]

On Fri, Sep 28, 2018 at 03:11:37PM +0300, Gabriel Ivăncescu wrote:
> On Fri, Sep 28, 2018 at 3:00 PM Nikolay Sivov  wrote:
> > On 09/28/2018 02:44 PM, Gabriel Ivăncescu wrote:
> > >       case WM_CHAR:
> > >       case WM_UNICHAR:
> > > -
> > >        if (wParam == This->no_fwd_char) return 0;
> > > -
> > >        This->no_fwd_char = '\0';
> > > -
> >
> > I don't know how important it is in practice, but shouldn't it go
> > through MapVirtualKey, storing VK_ code instead of a char?
>
> Isn't that the opposite effect of what's needed here? Or are you
> saying I should use it when setting no_fwd_char itself? In that case,
> I don't think it will work for the return key, since it's different
> depending on whether CTRL is pressed or not (like in quickComplete).

I'm wondering whether a simple flag 'ignore_next_char' would be cleaner.

Huw.