On 01/30/2011 12:02 PM, Peter Schlaile wrote:
Nevertheless: I hope, I explained pretty well, how and why the current code is wrong (aquiring a bitmap-pointer using CreateDIBSection, setting this bitmap to readonly using the fast track code path within StretchDIBits, writing to this bitmap again.).
Sounds plausible to me, but I'm not expert in that area.
probably, but you will agree, that this is a rather trivial change... (and pretty obvious, too).
No, me and everyone else here won't agree. Please send a separate patch with explanation why the change is needed. Each patch have to contain one change and one change only. No exceptions. Please see patch submission guidelines here: http://wiki.winehq.org/SubmittingPatches
Vitaliy.