Re: [PATCH v5] gdi32/tests: Add tests for the advanced graphics mode

[Dmitry Timoshkov]

Ralf Habacker  wrote:
> +typedef struct {
> - const char *name;
> - double shearX;
> - double angle;
> - const char *sha1;
>
> +} ref_hash_table_entry;
> -
>
> +typedef struct {
> - HDC dc;
> - BITMAPINFO *bmi;
> - BYTE *bits;
> - HBITMAP dib;
> - char *hash_dib;
> - char test_name[1024];
> - char save_path[MAX_PATH];
> - char hash_name[1024];
> - RECT bounds;
> - double angle;
> - double shearX;
>
> +} test_data;
> -
>
> +/* generated on Windows 10 */
> +ref_hash_table_entry ref_hash_table[] = {

...
> +static test_data _test_data;
> +test_data *td = &_test_data;
> -
>
> +double radians ( double d )
> +{
> - return d * M_PI / 180;
>
> +}

Please make arrays static const, helper functions static, avoid needless
typedefs, doubles, probably replace GlobalAlloc() by HeapAlloc(), avoid
hungarian notation.