2017-06-12 13:22 GMT+02:00 Paul Gofman gofmanp@gmail.com:
When count in const_upload_info is calculated precisely (considering actual constant set length), boolean matrix setting always fall in direct copy path. The test has both row_major and column_major qualified boolean matrices, but the qualifier is ignored by compiler.
Is it? The effect parameter is always row major, but it looks like the constant is actually affected (and you're handling that correctly AFAICS).
If change the type of matrix to int, the matrix goes to float constants and not to bool constants. So it looks like the case of incomplete last row for matrix should now never happen.
Right, and the FIXME you're adding in this patch should trigger if any of those assumptions turns out to be invalid. Looks good.