Re: [PATCH v3] winex11.drv: Add video adapter description to the registry.

[Dmitry Timoshkov]

Zhiyi Zhang  wrote:
> > - if (RegSetValueExW(hkey, adapter_stringW, 0, REG_SZ, (const BYTE *)gpu->name, size))
> > -
> >    goto done;
> > - if (RegSetValueExW(hkey, bios_stringW, 0, REG_SZ, (const BYTE *)gpu->name, size))
> > -
> >    goto done;
> > - if (RegSetValueExW(hkey, chip_typeW, 0, REG_SZ, (const BYTE *)gpu->name, size))
> > -
> >    goto done;
> > - if (RegSetValueExW(hkey, dac_typeW, 0, REG_SZ, (const BYTE *)ramdacW, sizeof(ramdacW)))
> > -
> >    goto done;
>
> I just checked on XP and Win7 on VirtualBox and Windows 10 21H1 on a physical machine with a AMD GPU.
> They are all REG_BINARY.

I have an NVidia card on that box, I'd guess then that it depends on a driver.
Having REG_SZ type seems more logical for string values, however if you insist
I could use REG_BINARY instead.