Re: ras.h added szDeviceType pound defines

[Michael Stefaniuc]

John Smith wrote:
> This is my first patch uhh ever so I guess don't just throw it  into the
> source without wariness. =P

Welcome to Wine.
> That said it just updates the list of #define strings that are acceptable
> device types for RASDEVINFO and RASENTRY.  This will fix some compilation
> issues against ras.h.
>
> There is more I could fix in ras.h but yeah my first time doing this, want
> to see how the patch process works,blah blah.

The Wine maintainer is this week on vacation so your patch would be
probably commited earliest in 1 week.
Do you know this page? http://www.winehq.org/site/sending_patches
> Anyway if anything about how I did this is wrong please let me know I hope
> to be a regular wino too =)

Not really wrong but some nitpick.
> From d294ed7e538a130ac10fad4bb2ac6a0f93120060 Mon Sep 17 00:00:00 2001
> From: John Klehm 
> Date: Tue, 30 Jan 2007 15:24:56 -0600
> Subject: [PATCH] Added additional szDeviceType pound defines.  These additions reflect
> http://msdn2.microsoft.com/en-us/library/aa377274.aspx
> and have been verified by a test program on Windows2000 and XP.
>
> include/ras.h |   19 +++++++++++++++++++
>  1 files changed, 19 insertions(+), 0 deletions(-)
>
> diff --git a/include/ras.h b/include/ras.h
> index c1f6d5c..ef289f4 100644
> --- a/include/ras.h
> +++ b/include/ras.h
> @@ -43,6 +43,25 @@ extern "C" {
>  #define	RASDT_Modem	"modem"
>  #define	RASDT_Isdn	"isdn"
>  #define	RASDT_X25	"x25"
> +/* more szDeviceType strings for RASDEVINFO
> -
> - from MSDN
> -
> - http://msdn2.microsoft.com/en-us/library/aa377274.aspx
> -
> - values taken from a test program on windows 2000 and XP
> -
> - Following are Windows 2000 and Windows XP values
> -
> - and above?
> - */

You do not need this comment. MSDN is so often updated that the link
will soon point to the void. Just document here the differences to MSDN
or other outstanding info.

Please use the same identing style like for the existing RASDT_* defines.
> +#define RASDT_Vpn	"vpn"
> +#define RASDT_Pad	"pad"
> +#define RASDT_Generic	"GENERIC"
> +#define RASDT_Serial	"SERIAL"
> +#define RASDT_FrameRelay "FRAMERELAY"
> +#define RASDT_Atm	"ATM"
> +#define RASDT_Sonet	"SONET"
> +#define RASDT_SW56	"SW56"
> +#define RASDT_Irda	"IRDA"
> +#define RASDT_Parallel	"PARALLEL"
> +/* Windows XP values. And above? */
> +#define RASDT_PPPoE	"PPPoE"
>
> #define RASBASE				600
>  #define ERROR_BUFFER_TOO_SMALL		(RASBASE+3)

bye
    michael