Re: [PATCH] wined3d: Reduce console flood with an Ogre3D Game

[Francois Gouget]

On Wed, 25 Jan 2012, Detlef Riekenberg wrote:
> On Sun, 2012-01-22 at 19:53 +0100, Henri Verbeet wrote:
> > On 22 January 2012 19:44, Detlef Riekenberg  wrote:
> > > - if (usage & ~handled)
> > > - static DWORD reported_once;
> > > -
> > > - if (usage & ~(handled | reported_once))
> > > - {
> > > -
> > >    reported_once |= (usage & ~handled);
> > >   FIXME("Unhandled usage flags %#x.\n", usage & ~handled);
> > > - }
> >
> > I don't think so.
>
> Sorry, I have no Idea, what objections do you have.

I don't pretend to know what Henry meant but reported_once is not 
initialized. It's probably put into a zero-initialized section by the 
compiler but it looks worrying to me (I believe something like this has 
been debated on the Linux kernel mailing list).

I did not try to check the bit manipulations.