Re: [PATCH] msvcrt: support I width modifier in *scanf* family

[Piotr Caban]

Hi Eric,

On 10/19/21 5:51 PM, Eric Pouech wrote:
> - strcpy(buffer,"12345678901234");
> - ret = p_sscanf(buffer, "%I64d", &result64);
> - ok(ret == 1, "Wrong number of arguments read: %d\n", ret);
> - ret = p_sprintf(buffer1, "%I64d", result64);
> - ok(ret==14 || broken(ret==10), "sprintf returned %d\n", ret);
> - if(ret == 14)
> -
>    ok(!strcmp(buffer, buffer1), "got %s, expected %s\n", buffer1, buffer);

Why are you testing printf output instead of checking result64 value? 
How about moving the tests to ucrtbase so you don't have to handle 
"broken" case (otherwise it's probably better to skip the test on old 
msvcrt)?

Thanks,
Piotr