On Fri, Sep 21, 2018 at 02:07:11PM +0300, Gabriel Ivăncescu wrote:
On Fri, Sep 21, 2018 at 1:55 PM, Huw Davies huw@codeweavers.com wrote:
Do you have an application that depends on this? If not, we should leave it as it is.
Huw.
Not that I'm aware of, but I thought matching Windows is a good idea here. I should probably still send it directly to the control though since it reduces needless overhead (especially due to GetPropW), but then the code can be simplified a bit if I don't have to special-case the WM_GETTEXT. The other hijack case needs to remain else I can't add WM_SETTEXT to the messages handled later since it would result in a recursive loop.
That said, It's a single extra call (get_edit_proc here), I don't think it's so bad to keep it like this since it's still better (behavior & overhead).
Well firstly, I very much doubt the overhead is going to be relevant for a user input driven auto-complete.
We don't necessarily want to copy Windows' implementation exactly--- indeed if it's possible we try to avoid that. As long as apps don't notice the difference it's fine.
Just make the changes that you need to add WM_SETTEXT.
Huw.