Re: shell32: Implement IApplicationAssociationRegistration QueryCurrentDefault (try 7 - resend)

[Nikolay Sivov]

On 13.02.2015 10:53, Alistair Leslie-Hughes wrote:

I would rearrange this a bit if I was doing it to make a patch shorter, 
and keep conditions nesting level lower, something like:

- get root key either from HKCR or HKCU;
- get a path to a value;
- have a single RegGetValueW() for all cases, once you know path.

But that's more of a suggestion, not a blocker.
> -
>        lstrcatW(path, slash);
> -
>        lstrcatW(path, query);
> -
>        lstrcatW(path, slash);
> -
>        lstrcatW(path, choice);

You could get rid of two calls if you move backslashes to 'choice' and 
'*assoc' strings.