Re: [PATCH] msxml3/tests: Test VBSAXXMLReader.

[Nikolay Sivov]

On 10/8/21 11:05 AM, Jefferson Carpenter wrote:
> Summary:
> - Generalized ContentHandler, ErrorHandler, and LexicalHandler
>
> implementations in test to not care about which interface is used.
> - Implemented SAX.*Handler interfaces by calling into these
>
> generalized functions.
> - Implemented VBSAX.*Handler interfaces the same way.

I think you could simply implement test handler objects that support
both interfaces, and switch between them using some flag.
> - Added vb_reader_support_data using VB interface IID_IVBSAXXMLReader.
> - Added a data structure containing both reader_support_data and
>
> vb_reader_support_data.  This is iterated over first in test_saxreader().

Is that necessary? Support data is meant for version-specific classes.
For SAXReader, it's never a situation when you can create C++ interface,
and not VB interface.
> The tests generally run.
>
> thanks,
> Jefferson