Re: [PATCH] taskschd/tests: Fix some memory leaks (Valgrind).

[Sven Baars]

On 15-01-19 15:20, Dmitry Timoshkov wrote:
> Sven Baars  wrote:
> >  hr = ITaskService_GetFolder(service, slash, &folder);
> >
> > todo_wine
> >      ok(hr == HRESULT_FROM_WIN32(ERROR_INVALID_NAME), "expected ERROR_INVALID_NAME, got %#x\n", hr);
> > -
> >
> > if (hr == S_OK) ITaskFolder_Release(folder);
> >
> > hr = ITaskService_GetFolder(service, dot, &folder);
> >
> > todo_wine
> >      ok(hr == HRESULT_FROM_WIN32(ERROR_INVALID_NAME) || hr == HRESULT_FROM_WIN32(ERROR_FILE_NOT_FOUND) /* win7 */,
> >         "expected ERROR_INVALID_NAME, got %#x\n", hr);
> > - if (hr == S_OK) ITaskFolder_Release(folder);
>
> Fixing Wine code and removing the todo_wine would be a more appropriate fix.

Of course, but at the moment I'm just trying to fix all memory leaks
that are present in the tests during the code freeze. That way it is
easier to find and fix actual memory leaks in wine itself after the code
freeze. I already have some patches lined up for that as well.

Best,
Sven