Re: [PATCH 1/4] d3drm: Implement IDirect3DRMFrameX_AddChild.

[Jacek Caban]

Hi Christian,

On 04/02/12 08:54, Christian Costa wrote:
> {
>      IDirect3DRMFrameImpl *This = impl_from_IDirect3DRMFrame2(iface);
> - LPDIRECT3DRMFRAME3 frame;
> - FIXME("(%p/%p)->(%p): stub\n", iface, This, child);
> - TRACE("(%p/%p)->(%p)\n", iface, This, child);
> - return E_NOTIMPL;
> - if (!child)
> -
>    return D3DRMERR_BADOBJECT;
> -
> - frame = &impl_from_IDirect3DRMFrame2((LPDIRECT3DRMFRAME2)child)->IDirect3DRMFrame3_iface;

This should be avoided. See unsafe_impl_from_* at
http://wiki.winehq.org/COMGuideline for an example.

Jacek