Hi,
Il 24/03/22 17:41, Zebediah Figura ha scritto:
On 3/23/22 07:44, Giovanni Mascellani wrote:
Signed-off-by: Giovanni Mascellani gmascellani@codeweavers.com
I don't think it is wrong as it is, but I would have found more idiomatic to put the check in declare_vars() outside of the loop iterating over all the variable declarations, given that it doesn't depend on the specific declaration. This way if multiple variables are declared with in or out modifiers in the same statement (as in "in int x, y, z;") the error message is uselessly outputted many times.
I don't know about idiomatic, but yes, they should be moved for the reason you describe. It's a preëxisting issue, though, for what it's worth.
I don't understand why you say it's preexisting: it's a block of code that you're adding, and that you might have added a few lines above, isn't it? Am I missing something?
BTW, I agree it can be fixed in a later commit anyway.
Giovanni.